Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds examples using the @first and @last Handlebars variables #4113

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

davidwrede
Copy link

Addresses #3805.

Signed-off-by: David Wrede [email protected]

@thesentinels
Copy link
Contributor

Thanks for the pull request! Here is what will happen next:

  1. Your PR will be reviewed by the maintainers
  2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

Copy link
Contributor

@elliott-davis elliott-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd just like to see the ~ at the end in the docs so it matches the core plans code.


"mongo": {
{{~#each bind.database.members as |member|}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in core plans were trying to standardize around ~ at the end of the handlebars syntax. https://github.com/habitat-sh/core-plans/pull/986/files

@davidwrede
Copy link
Author

Feedback incorporated and ready for another review.

Copy link
Contributor

@elliott-davis elliott-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-158065280

@elliott-davis
Copy link
Contributor

@thesentinels approve

@thesentinels
Copy link
Contributor

🤘 I am testing your branch against master before merging it. We do this to ensure that the master branch is never failing tests.

@thesentinels
Copy link
Contributor

:neckbeard: Travis CI has started testing this PR.

@thesentinels
Copy link
Contributor

💖 Travis CI reports this PR passed.

It always makes me feel nice when humans approve of one anothers work. I'm merging this PR now.

I just want you and the contributor to answer me one question:

gif-keyboard-3280869874741411265

@thesentinels thesentinels merged commit 78633c5 into master Nov 28, 2017
@thesentinels thesentinels deleted the dw/each_update branch November 28, 2017 18:21
@christophermaier christophermaier added Documentation Flags an issue / PR for attention by the technical documentation team and removed A-documentation labels Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Flags an issue / PR for attention by the technical documentation team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants